Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make memes collapsible #40

Open
dylf opened this issue Nov 2, 2020 · 2 comments
Open

Make memes collapsible #40

dylf opened this issue Nov 2, 2020 · 2 comments
Labels
Type/Enhancement New feature or improvement of existing feature

Comments

@dylf
Copy link

dylf commented Nov 2, 2020

It would be nice to have the meme images collapsable like media embedded via a link in mattermost.
image

image
@hanzei hanzei added the Type/Enhancement New feature or improvement of existing feature label Dec 2, 2020
@ghost
Copy link

ghost commented Mar 1, 2021 •
edited by ghost
Loading

This is doable by not posting the link to the generated image in markdown but only posting the link as it is.
IMO this should be opt-in with a configuration switch.

The relevant line is in server/plugin.go on line 201:
replace

    Text:         "![" + template.Name + "](" + siteURL + "/plugins/memes-adsy/templates/" + template.Name + ".jpg" + queryString + ")",

with

    Text:         siteURL + "/plugins/memes-adsy/templates/" + template.Name + ".jpg" + queryString,

@ghost
Copy link

ghost commented Mar 5, 2021

I started to work on it: https://github.com/aconitumnapellus/mattermost-plugin-memes/commits/feature/opt_in_preview

@Roujo Roujo mentioned this issue Mar 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type/Enhancement New feature or improvement of existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dylf @hanzei