From f7b59720272964e556ed94fe85231dda5e6fe0d8 Mon Sep 17 00:00:00 2001 From: Abdul Sattar Mapara Date: Mon, 6 Jul 2020 17:03:26 +0530 Subject: [PATCH 1/3] Provided feedback on invalid slash command --- server/command.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/server/command.go b/server/command.go index a376474..fa087b1 100644 --- a/server/command.go +++ b/server/command.go @@ -314,6 +314,9 @@ func (p *Plugin) ExecuteCommand(c *plugin.Context, args *model.CommandArgs) (*mo p.API.LogError("Error while creating the job.", err.Error()) return p.getCommandResponse(args, "Encountered an error while creating the job"), nil } + default: + text := "###### Mattermost Jenkins Plugin - Slash Command Help\n" + strings.Replace(helpText, "|", "`", -1) + return p.getCommandResponse(args, text), nil } return &model.CommandResponse{}, nil } From a9dbe959c52e0199c0f04faf34885df9abeda629 Mon Sep 17 00:00:00 2001 From: Abdul Sattar Mapara Date: Wed, 8 Jul 2020 20:09:25 +0530 Subject: [PATCH 2/3] Added unknown command message for invalid slash command --- server/command.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/command.go b/server/command.go index fa087b1..85e1859 100644 --- a/server/command.go +++ b/server/command.go @@ -315,7 +315,7 @@ func (p *Plugin) ExecuteCommand(c *plugin.Context, args *model.CommandArgs) (*mo return p.getCommandResponse(args, "Encountered an error while creating the job"), nil } default: - text := "###### Mattermost Jenkins Plugin - Slash Command Help\n" + strings.Replace(helpText, "|", "`", -1) + text := "###### Unknown Command: " + action + "\n\n" + "###### Mattermost Jenkins Plugin - Slash Command Help\n" + strings.Replace(helpText, "|", "`", -1) return p.getCommandResponse(args, text), nil } return &model.CommandResponse{}, nil From b0bd78af0e70b0329155a24c1c2e1f27a2ac1b95 Mon Sep 17 00:00:00 2001 From: Abdul Sattar Mapara Date: Wed, 8 Jul 2020 20:11:57 +0530 Subject: [PATCH 3/3] Changed two line breaks to one after Unknown command message --- server/command.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/command.go b/server/command.go index 85e1859..66cb7d4 100644 --- a/server/command.go +++ b/server/command.go @@ -315,7 +315,7 @@ func (p *Plugin) ExecuteCommand(c *plugin.Context, args *model.CommandArgs) (*mo return p.getCommandResponse(args, "Encountered an error while creating the job"), nil } default: - text := "###### Unknown Command: " + action + "\n\n" + "###### Mattermost Jenkins Plugin - Slash Command Help\n" + strings.Replace(helpText, "|", "`", -1) + text := "###### Unknown Command: " + action + "\n" + "###### Mattermost Jenkins Plugin - Slash Command Help\n" + strings.Replace(helpText, "|", "`", -1) return p.getCommandResponse(args, text), nil } return &model.CommandResponse{}, nil