Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group Id field should be hidden from UI when not applicable with current license #27

Open
DHaussermann opened this issue Mar 2, 2020 · 1 comment
Open

Group Id field should be hidden from UI when not applicable with current license #27

DHaussermann opened this issue Mar 2, 2020 · 1 comment
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Tech/ReactJS Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@DHaussermann
Copy link

DHaussermann commented Mar 2, 2020 •
edited by hanzei
Loading

When a server is running Team Edition the Admin UI will still show the Group ID field for Custom Attributes configuration.

This is of no value as LDAP group sync is unavailable and is confusing to use.

Group ID field should only be available when the current licence supports LDAP groups.

LDAP Groups are available in Enterprise Edition. In order to test the changes in this ticket, please open a PR as WIP first and a Mattermost Core Comitter can set up an EE server for testing.
@DHaussermann DHaussermann mentioned this issue Mar 2, 2020
Merged
@aaronrothschild
Copy link
Contributor

Confusing because the field is there, even without EE licence.

@hanzei hanzei added Difficulty/2:Medium Medium ticket Help Wanted Community help wanted Tech/Go Tech/ReactJS Up For Grabs Ready for help from the community. Removed when someone volunteers Type/Enhancement New feature or improvement of existing feature and removed Triage labels Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Tech/ReactJS Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jespino @aaronrothschild @larkox @cpanato @hanzei @DHaussermann