From 18199038af6ff64c21de99fcf698fdb98a2f5d2b Mon Sep 17 00:00:00 2001
From: Jason Frerich <jason.frerich@mattermost.com>
Date: Wed, 15 Jul 2020 21:34:43 -0500
Subject: [PATCH 1/2] remove the readonly props from all fields.  Want to allow
 user to edit existing subscription

---
 .../src/components/subscription_modal/subscription_modal.jsx | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/webapp/src/components/subscription_modal/subscription_modal.jsx b/webapp/src/components/subscription_modal/subscription_modal.jsx
index 1828c7e..3b2b5d8 100644
--- a/webapp/src/components/subscription_modal/subscription_modal.jsx
+++ b/webapp/src/components/subscription_modal/subscription_modal.jsx
@@ -166,7 +166,6 @@ export default class SubscriptionModal extends React.PureComponent {
                 type={'text'}
                 fieldType={'input'}
                 required={true}
-                readOnly={editSubscription}
                 placeholder={'Enter the Confluence Space Key.'}
                 value={this.state.spaceKey}
                 addValidation={this.validator.addValidation}
@@ -183,7 +182,6 @@ export default class SubscriptionModal extends React.PureComponent {
                     type={'text'}
                     fieldType={'input'}
                     required={true}
-                    readOnly={editSubscription}
                     placeholder={'Enter the page id.'}
                     value={this.state.pageID}
                     addValidation={this.validator.addValidation}
@@ -198,7 +196,6 @@ export default class SubscriptionModal extends React.PureComponent {
                     formGroupStyle={getStyle.subscriptionType}
                     isSearchable={false}
                     isMulti={false}
-                    isDisabled={editSubscription}
                     label={'Subscribe To'}
                     name={'type'}
                     fieldType={'dropDown'}
@@ -244,7 +241,6 @@ export default class SubscriptionModal extends React.PureComponent {
                             type={'text'}
                             fieldType={'input'}
                             required={true}
-                            readOnly={editSubscription}
                             placeholder={'Enter a name for this subscription.'}
                             value={this.state.alias}
                             addValidation={this.validator.addValidation}
@@ -256,7 +252,6 @@ export default class SubscriptionModal extends React.PureComponent {
                             type={'text'}
                             fieldType={'input'}
                             required={true}
-                            readOnly={editSubscription}
                             placeholder={'Enter the Confluence Base URL.'}
                             value={this.state.baseURL}
                             addValidation={this.validator.addValidation}

From 4ecdf87e90d0f9b7605d17f39abf5dac34890916 Mon Sep 17 00:00:00 2001
From: Jason Frerich <jason.frerich@mattermost.com>
Date: Wed, 15 Jul 2020 21:36:22 -0500
Subject: [PATCH 2/2] update test

---
 .../__snapshots__/subscription_modal.test.jsx.snap               | 1 -
 1 file changed, 1 deletion(-)

diff --git a/webapp/src/components/subscription_modal/__snapshots__/subscription_modal.test.jsx.snap b/webapp/src/components/subscription_modal/__snapshots__/subscription_modal.test.jsx.snap
index e8cffd7..5c122cf 100644
--- a/webapp/src/components/subscription_modal/__snapshots__/subscription_modal.test.jsx.snap
+++ b/webapp/src/components/subscription_modal/__snapshots__/subscription_modal.test.jsx.snap
@@ -88,7 +88,6 @@ exports[`components/ChannelSettingsModal subscription modal snapshot test 1`] =
               "marginRight": "20px",
             }
           }
-          isDisabled={false}
           isMulti={false}
           isSearchable={false}
           label="Subscribe To"