Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue - 28] Security: Regular User is allowed to view and manage list of subscriptions belonging to a different user #76

Closed

Conversation

sibasankarnayak
Copy link
Contributor

fixed the logic normal user can not access the subscription of other users

ticket here
Fixes #28

@mattermod
Copy link
Contributor

Hello @sibasankarnayak,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@codecov-commenter
Copy link

Codecov Report

Merging #76 (d06b6fc) into master (806f094) will not change coverage.
The diff coverage is 16.66%.

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   16.18%   16.18%           
=======================================
  Files          13       13           
  Lines        1853     1853           
=======================================
  Hits          300      300           
  Misses       1534     1534           
  Partials       19       19           
Impacted Files Coverage Δ
server/command.go 6.79% <0.00%> (ø)
server/subscriptions.go 14.51% <28.57%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 806f094...d06b6fc. Read the comment docs.

@hanzei hanzei added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Apr 6, 2022
@mickmister
Copy link
Contributor

According to #28 (comment), this should not be implemented until the design is revisited

@mickmister
Copy link
Contributor

Closing this for now until the feature has been designed

@mickmister mickmister closed this Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester Lifecycle/1:stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security: Regular User is allowed to view and manage list of subscriptions belonging to a different user
5 participants