Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: The Bitbucket refresh tokens are not encrypted and stored in DB #23

Open
jfrerich opened this issue May 25, 2021 · 0 comments
Labels
Help Wanted Community help wanted Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@jfrerich
Copy link
Contributor

jfrerich commented May 25, 2021

From comment #5 (review)

1) The Bitbucket refresh tokens are not encrypted and stored in DB

Severity: High

Steps:

  • When a user connects to a bitbucket account, the connection refresh_token is stored as plain text in DB. This value is not encrypted and stored.

  • As a result, anyone can obtain a new access_token and the point of having an encrypted access_token in DB will be lost.
    curl -X POST -u "key:secret" https://bitbucket.org/site/oauth2/access_token -d grant_type=refresh_token -d refresh_token=refresh_token

  • Since a Bitbucket comprises of a user's personal account also, anyone who possesses this info from DB, can access user's other private repositories not supposed to be shared.

@jfrerich jfrerich added Difficulty/2:Medium Medium ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Type/Enhancement New feature or improvement of existing feature and removed Good First Issue Suitable for first-time contributors Help Wanted Community help wanted labels Jul 1, 2021
@hanzei hanzei added the Needs Mattermost Changes Requires changes to the Mattermost Plugin tookit label Jul 1, 2021
@hanzei hanzei added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers and removed Needs Mattermost Changes Requires changes to the Mattermost Plugin tookit Difficulty/2:Medium Medium ticket labels Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Community help wanted Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Development

No branches or pull requests

2 participants