-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal for Add subscription cannot be saved as there is a "Requested By" drop down below that takes my focus #142
Comments
After updating Chrome to latest |
Also I notice this working normally for a while and then start to cause issues again when opening the app in. a second browser tab. |
This appears resolved in Resolved in #141 @avas27JTG I am no longer able to reproduce this issue. I'd like to do some more targeted testing. Could you (or one of your peers) please provide some high level detail about the underlying problem that had to be solved here? |
@DHaussermann This issue has been fixed in the latest commit pushed on the branch epic_phase_3 also, the latest release v3.1.1 is deployed on the MM app that contains fixes for all of the issues reported here on the GitHub Please verify and close it. The underlying problem was the missing Mattermost web app's CSS classes which are now added to the plugin. |
Oh okay. Thanks @avas27JTG . Because it was intermittent I was concerned there was a more complex issue. That's fine. Thanks for sharing. This can also close once #141 merges. |
Something may have changed (possibly on my Azure side) but I now see a field called Requested By with groups in it.
I'm not sure why the filed appeared and it's probably not an issue at all but - The field takes my focus when I try to click save or cancel now. I am unable to to finish creating the subscription.
Can the modal have dynamic vertical height to fit all elements - or be scrollable so all elements can fit above the save button.
Edit: This server was recently upgraded to lated
master
(To side step a webapp issue where some Azure options were cut off) Trimming wise it's true that I did not observe the issue before upgrading the code - possibly it's relevant.The text was updated successfully, but these errors were encountered: