Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal for Add subscription cannot be saved as there is a "Requested By" drop down below that takes my focus #142

Open
DHaussermann opened this issue Jan 18, 2023 · 5 comments
Labels
Type/Bug Something isn't working

Comments

@DHaussermann
Copy link

DHaussermann commented Jan 18, 2023

Something may have changed (possibly on my Azure side) but I now see a field called Requested By with groups in it.

image

I'm not sure why the filed appeared and it's probably not an issue at all but - The field takes my focus when I try to click save or cancel now. I am unable to to finish creating the subscription.

Can the modal have dynamic vertical height to fit all elements - or be scrollable so all elements can fit above the save button.

Edit: This server was recently upgraded to lated master (To side step a webapp issue where some Azure options were cut off) Trimming wise it's true that I did not observe the issue before upgrading the code - possibly it's relevant.
image

@DHaussermann DHaussermann added Type/Bug Something isn't working Triage labels Jan 18, 2023
@DHaussermann
Copy link
Author

After updating Chrome to latest Version 109.0.5414.87 (Official Build) (arm64) (I think it was older) and restarting the application - I now see scroll bars as expected.

@DHaussermann
Copy link
Author

Also I notice this working normally for a while and then start to cause issues again when opening the app in. a second browser tab.

@DHaussermann
Copy link
Author

This appears resolved in Resolved in #141

@avas27JTG I am no longer able to reproduce this issue. I'd like to do some more targeted testing. Could you (or one of your peers) please provide some high level detail about the underlying problem that had to be solved here?

@avas27JTG
Copy link
Contributor

avas27JTG commented Jan 24, 2023

This appears resolved in Resolved in #141

@avas27JTG I am no longer able to reproduce this issue. I'd like to do some more targeted testing. Could you (or one of your peers) please provide some high level detail about the underlying problem that had to be solved here?

@DHaussermann This issue has been fixed in the latest commit pushed on the branch epic_phase_3 also, the latest release v3.1.1 is deployed on the MM app that contains fixes for all of the issues reported here on the GitHub

Please verify and close it.

The underlying problem was the missing Mattermost web app's CSS classes which are now added to the plugin.

@DHaussermann
Copy link
Author

Oh okay. Thanks @avas27JTG . Because it was intermittent I was concerned there was a more complex issue.

That's fine. Thanks for sharing. This can also close once #141 merges.

@mickmister mickmister removed the Triage label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type/Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants