Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(proof-data-handler): return 204 HTTP status code if no proofs are available #3037

Merged
merged 3 commits into from
Oct 10, 2024
Merged

feat(proof-data-handler): return 204 HTTP status code if no proofs are available #3037

merged 3 commits into from
Oct 10, 2024

Conversation

pbeza
Copy link
Collaborator

@pbeza pbeza commented Oct 8, 2024

What ❔

Return 204 (No Content) HTTP status code if no proofs are available.

Why ❔

We were getting an HTTP 200 response with null as the result when hitting the /tee/proof_inputs endpoint, which doesn’t seem right.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk_supervisor fmt and zk_supervisor lint.

@pbeza pbeza changed the base branch from main to tee_prover_new_2 October 8, 2024 14:16
@pbeza pbeza force-pushed the tee/feat/return-402-http-status-code-if-no-proofs-available branch from 2346f52 to 1fca59e Compare October 8, 2024 14:51
@pbeza pbeza force-pushed the tee/feat/return-402-http-status-code-if-no-proofs-available branch from 1fca59e to 77f44fd Compare October 9, 2024 15:55
@pbeza pbeza force-pushed the tee/feat/return-402-http-status-code-if-no-proofs-available branch 2 times, most recently from cc02bfb to 6bbe4f4 Compare October 9, 2024 18:05
@pbeza pbeza marked this pull request as ready for review October 9, 2024 18:29
@pbeza pbeza force-pushed the tee/feat/return-402-http-status-code-if-no-proofs-available branch from 6bbe4f4 to f8a249f Compare October 9, 2024 18:30
@pbeza pbeza mentioned this pull request Oct 9, 2024
Merged
4 tasks
@pbeza pbeza force-pushed the tee/feat/return-402-http-status-code-if-no-proofs-available branch from f8a249f to 70c82b6 Compare October 9, 2024 19:45
@haraldh haraldh merged commit f7e1caa into tee_prover_new_2 Oct 10, 2024
32 checks passed
@haraldh haraldh deleted the tee/feat/return-402-http-status-code-if-no-proofs-available branch October 10, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbeza @haraldh