fix(vm): fix circuit tracer #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detected VM performance changes
|
StanislavBreadless
approved these changes
Jan 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
🤖 I have created a release *beep* *boop* --- ## [19.1.0](core-v19.0.0...core-v19.1.0) (2024-01-10) ### Features * address remaining spelling issues in dev comments and turns on dev_comments in cfg ([#827](#827)) ([1fd0afd](1fd0afd)) * **core:** removes multiple tokio runtimes and worker number setting. ([#826](#826)) ([b8b190f](b8b190f)) * fix spelling in dev comments in `core/lib/*` - continued ([#683](#683)) ([0421fe6](0421fe6)) * fix spelling in dev comments in `core/lib/*` - continued ([#684](#684)) ([b46c2e9](b46c2e9)) * fix spelling in dev comments in `core/lib/multivm` - continued ([#682](#682)) ([3839d39](3839d39)) * fix spelling in dev comments in `core/lib/zksync_core` - continued ([#685](#685)) ([70c3feb](70c3feb)) * **state-keeper:** circuits seal criterion ([#729](#729)) ([c4a86bb](c4a86bb)) * **state-keeper:** Reject transactions that fail to publish bytecodes ([#832](#832)) ([0a010f0](0a010f0)) * **vm:** Add batch input abstraction ([#817](#817)) ([997db87](997db87)) ### Bug Fixes * oldest unpicked batch ([#692](#692)) ([a6c869d](a6c869d)) * **state-keeper:** Updates manager keeps track of fictive block metrics ([#843](#843)) ([88fd724](88fd724)) * **vm:** fix circuit tracer ([#837](#837)) ([83fc7be](83fc7be)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
finish_cyclemethod of circuit tracer wasn't called and there were bugs in it.Why ❔
Fix tracer
Checklist
zk fmtandzk lint.cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.