Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): removes multiple tokio runtimes and worker number setting. #826

Merged
merged 13 commits into from
Jan 9, 2024

Conversation

montekki
Copy link
Contributor

@montekki montekki commented Jan 6, 2024

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.

@montekki montekki marked this pull request as ready for review January 8, 2024 11:43
@montekki
Copy link
Contributor Author

montekki commented Jan 8, 2024

This generally looks to work in CI, but i think that we should add some config variables deprication warning

@montekki montekki requested a review from popzxc January 8, 2024 12:55
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

core/bin/external_node/src/config/mod.rs Show resolved Hide resolved
popzxc
popzxc previously approved these changes Jan 9, 2024
@montekki montekki enabled auto-merge January 9, 2024 10:54
@montekki montekki disabled auto-merge January 9, 2024 10:56
@montekki montekki added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit b8b190f Jan 9, 2024
25 checks passed
@montekki montekki deleted the fvs-remove-multiple-tokio-runtimes branch January 9, 2024 11:52
github-merge-queue bot pushed a commit that referenced this pull request Jan 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[19.1.0](core-v19.0.0...core-v19.1.0)
(2024-01-10)


### Features

* address remaining spelling issues in dev comments and turns on
dev_comments in cfg
([#827](#827))
([1fd0afd](1fd0afd))
* **core:** removes multiple tokio runtimes and worker number setting.
([#826](#826))
([b8b190f](b8b190f))
* fix spelling in dev comments in `core/lib/*` - continued
([#683](#683))
([0421fe6](0421fe6))
* fix spelling in dev comments in `core/lib/*` - continued
([#684](#684))
([b46c2e9](b46c2e9))
* fix spelling in dev comments in `core/lib/multivm` - continued
([#682](#682))
([3839d39](3839d39))
* fix spelling in dev comments in `core/lib/zksync_core` - continued
([#685](#685))
([70c3feb](70c3feb))
* **state-keeper:** circuits seal criterion
([#729](#729))
([c4a86bb](c4a86bb))
* **state-keeper:** Reject transactions that fail to publish bytecodes
([#832](#832))
([0a010f0](0a010f0))
* **vm:** Add batch input abstraction
([#817](#817))
([997db87](997db87))


### Bug Fixes

* oldest unpicked batch
([#692](#692))
([a6c869d](a6c869d))
* **state-keeper:** Updates manager keeps track of fictive block metrics
([#843](#843))
([88fd724](88fd724))
* **vm:** fix circuit tracer
([#837](#837))
([83fc7be](83fc7be))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants