Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: da_dispatcher refactoring #3409

Merged
merged 13 commits into from
Jan 8, 2025
Merged

feat: da_dispatcher refactoring #3409

merged 13 commits into from
Jan 8, 2025

Conversation

dimazhornyk
Copy link
Contributor

@dimazhornyk dimazhornyk commented Dec 20, 2024 •
edited
Loading

What ❔

  • Don't assume NoDA Validium by default, make the config required even for no DA, that helps avoid misconfiguration issues
  • Separate threads in da_dispatcer for dispatch and poll_for_inclusion
  • Change the default amount of rows that are fetched for dispatching

Why ❔

To make configuration more resilient and main logic more efficient.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

shahar4
shahar4 reviewed Jan 7, 2025
View reviewed changes
core/bin/zksync_server/src/node_builder.rs Outdated Show resolved Hide resolved
core/bin/zksync_server/src/node_builder.rs Show resolved Hide resolved
core/lib/config/src/configs/da_dispatcher.rs Show resolved Hide resolved
core/lib/protobuf_config/src/da_client.rs Show resolved Hide resolved
core/node/da_clients/src/avail/sdk.rs Outdated Show resolved Hide resolved
perekopskiy
perekopskiy previously approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@perekopskiy perekopskiy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please answer to Shahar's comments. Also, please change PR title to feat, chore should be used only for non-functional changes

@dimazhornyk dimazhornyk changed the title chore: da_dispatcher refactoring feat: da_dispatcher refactoring Jan 7, 2025
shahar4
shahar4 previously approved these changes Jan 8, 2025
View reviewed changes
core/lib/protobuf_config/src/da_client.rs Show resolved Hide resolved
core/lib/config/src/configs/da_dispatcher.rs Show resolved Hide resolved
@dimazhornyk dimazhornyk added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 591cd86 Jan 8, 2025
44 checks passed
@dimazhornyk dimazhornyk deleted the dz-da-dispatcher-improvements branch January 8, 2025 11:21
@zksync-era-bot zksync-era-bot mentioned this pull request Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perekopskiy perekopskiy perekopskiy approved these changes

@shahar4 shahar4 shahar4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimazhornyk @shahar4 @perekopskiy