feat: FFLONK support for compressor #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.lock # prover/Cargo.lock # zkstack_cli/crates/zkstack/src/commands/chain/init/configs.rs
EmilLuta
reviewed
Dec 30, 2024
There was a problem hiding this comment.
Overall looks fine. I reckon the latest changes on ZK Stack API will need a .sh regen (I doubt it's a flaky test).
Then there's the follow-ups we discussed on this:
- speeding up the generation
- move compressor to the new processing interface
- make keystore use env var, rather than compilation flag
As soon as the CI passes, happy to re-review & approve.
EmilLuta
previously approved these changes
Jan 2, 2025
alexandrst88
requested changes
Jan 2, 2025
alexandrst88
previously approved these changes
Jan 2, 2025
EmilLuta
approved these changes
Jan 2, 2025
alexandrst88
approved these changes
Jan 2, 2025
This was referenced Jan 2, 2025
popzxc
reviewed
Jan 3, 2025
Comment on lines
+231
to
+233
| circuit_encodings = "0.150.19" | ||
| circuit_sequencer_api = "0.150.19" | ||
| circuit_definitions = "0.150.19" |
There was a problem hiding this comment.
It is a bad idea to unlock the version. The latest version of crypto/protocol crates must be pinned to the last one; otherwise cargo update can bump the version in lockfile automatically.
Pls return = to all the crates where it was removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Enables support of FFLONK compression
--flonk=trueflag to run compressor in FFLONK mode(or by runningzkstack prover run --component compressor --mode=fflonk), default mode is still PLONKL1BatchProofForL1::FflonkorL1BatchProofForL1::Plonkcontaining the proof insidecompression_modeenvironment variable - FFLONK compressor can be run in 5 modes - 5th one is the most effective, so default value is 5.Why ❔
Checklist
zk fmtandzk lint.