fix(state-keeper): Add GasForBatchTip criterion #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perekopskiy
requested review from
RomanBrodetski,
Deniallugo and
StanislavBreadless
Deniallugo
reviewed
Feb 16, 2024
core/lib/zksync_core/src/state_keeper/seal_criteria/criteria/gas_for_batch_tip.rs
Outdated
Show resolved
Hide resolved
StanislavBreadless
approved these changes
Feb 16, 2024
Deniallugo
approved these changes
Feb 16, 2024
RomanBrodetski
pushed a commit
that referenced
this pull request
Feb 26, 2024
🤖 I have created a release *beep* *boop* --- ## [20.8.0](core-v20.7.0...core-v20.8.0) (2024-02-26) ### Features * Add more buckets to call tracer ([#1137](#1137)) ([dacd8c9](dacd8c9)) * **api:** add a config flag for disabling filter api ([#1078](#1078)) ([b486d7e](b486d7e)) * **api:** Create RPC method to return all tokens ([#1103](#1103)) ([b538d1a](b538d1a)) * **api:** Implement TxSink abstraction ([#1204](#1204)) ([11a34d4](11a34d4)) * **en:** Add health checks for EN components ([#1088](#1088)) ([4ea1520](4ea1520)) * **en:** Start health checks early into EN lifecycle ([#1146](#1146)) ([f983e80](f983e80)) * **en:** switch to tree light mode ([#1152](#1152)) ([ce6c120](ce6c120)) * **en:** Take into account nonce from tx proxy ([#995](#995)) ([22099cb](22099cb)) * **healthcheck:** Various healthcheck improvements ([#1166](#1166)) ([1e34148](1e34148)) * Integration tests enhancement for L1 ([#1209](#1209)) ([a1c866c](a1c866c)) * **node_framework:** Support Eth Watch in the framework ([#1145](#1145)) ([4f41b68](4f41b68)) * **shared bridge:** preparation for shared bridge migration (server) ([#1012](#1012)) ([2a766a7](2a766a7)) * **vlog:** Remove env getters from vlog ([#1077](#1077)) ([00d3429](00d3429)) * **vm:** Add new VM folder ([#1208](#1208)) ([66cdefc](66cdefc)) * **vm:** integrate new vm version ([#1215](#1215)) ([63d1f52](63d1f52)) ### Bug Fixes * **contract-verifier:** Add force_evmla flag ([#1179](#1179)) ([e75aa11](e75aa11)) * **contract-verifier:** allow other zksolc settings ([#1174](#1174)) ([72c60bd](72c60bd)) * **state-keeper:** Add GasForBatchTip criterion ([#1096](#1096)) ([de4d729](de4d729)) ### Performance Improvements * **db:** Improve `get_logs_by_tx_hashes` query ([#1171](#1171)) ([0dda7cc](0dda7cc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
That check in batch executor
conceptually was a criterion and should be extracted to a separate seal criteria. This way EN doesn't perform this check which is a correct behavior and code is cleaner.
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.