From 1ecab0dadc76ead02e233c71aaa73b6a469b103e Mon Sep 17 00:00:00 2001 From: Igor Aleksanov Date: Wed, 10 Jul 2024 21:37:52 +0400 Subject: [PATCH] chore: Fix a few warnings (#2396) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## What ❔ Fixes a few warnings, mostly in the prover workspace. ## Why ❔ Developing with warnings in the tree increases the warning blindness. ## Checklist - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. --- infrastructure/zk/src/lint.ts | 2 +- prover/proof_fri_compressor/src/main.rs | 1 + prover/prover_fri/src/lib.rs | 1 + prover/prover_fri/src/main.rs | 1 + prover/witness_generator/src/lib.rs | 1 + prover/witness_generator/src/main.rs | 1 + prover/witness_vector_generator/src/lib.rs | 1 + prover/witness_vector_generator/src/main.rs | 1 + 8 files changed, 8 insertions(+), 1 deletion(-) diff --git a/infrastructure/zk/src/lint.ts b/infrastructure/zk/src/lint.ts index 84c2c4535c59..7a24881c0f96 100644 --- a/infrastructure/zk/src/lint.ts +++ b/infrastructure/zk/src/lint.ts @@ -35,7 +35,7 @@ async function clippy() { async function proverClippy() { process.chdir(`${process.env.ZKSYNC_HOME}/prover`); - await utils.spawn('cargo clippy --tests --locked -- -D warnings -A incomplete_features'); + await utils.spawn('cargo clippy --tests --locked -- -D warnings'); } async function toolboxClippy() { diff --git a/prover/proof_fri_compressor/src/main.rs b/prover/proof_fri_compressor/src/main.rs index f48a4e785f14..8be498be5e00 100644 --- a/prover/proof_fri_compressor/src/main.rs +++ b/prover/proof_fri_compressor/src/main.rs @@ -1,3 +1,4 @@ +#![allow(incomplete_features)] // We have to use generic const exprs. #![feature(generic_const_exprs)] use std::{env, time::Duration}; diff --git a/prover/prover_fri/src/lib.rs b/prover/prover_fri/src/lib.rs index 8d57083ebd36..39757795d980 100644 --- a/prover/prover_fri/src/lib.rs +++ b/prover/prover_fri/src/lib.rs @@ -1,3 +1,4 @@ +#![allow(incomplete_features)] // We have to use generic const exprs. #![feature(generic_const_exprs)] mod metrics; pub mod prover_job_processor; diff --git a/prover/prover_fri/src/main.rs b/prover/prover_fri/src/main.rs index 824200bdf0ab..dfab8648d74c 100644 --- a/prover/prover_fri/src/main.rs +++ b/prover/prover_fri/src/main.rs @@ -1,3 +1,4 @@ +#![allow(incomplete_features)] // We have to use generic const exprs. #![feature(generic_const_exprs)] use std::{future::Future, sync::Arc, time::Duration}; diff --git a/prover/witness_generator/src/lib.rs b/prover/witness_generator/src/lib.rs index 0e6f7ddf6805..a80f06312d12 100644 --- a/prover/witness_generator/src/lib.rs +++ b/prover/witness_generator/src/lib.rs @@ -1,3 +1,4 @@ +#![allow(incomplete_features)] // We have to use generic const exprs. #![feature(generic_const_exprs)] pub mod basic_circuits; diff --git a/prover/witness_generator/src/main.rs b/prover/witness_generator/src/main.rs index 6266d030544b..caad9458827e 100644 --- a/prover/witness_generator/src/main.rs +++ b/prover/witness_generator/src/main.rs @@ -1,3 +1,4 @@ +#![allow(incomplete_features)] // We have to use generic const exprs. #![feature(generic_const_exprs)] use std::time::{Duration, Instant}; diff --git a/prover/witness_vector_generator/src/lib.rs b/prover/witness_vector_generator/src/lib.rs index d9d47d54897c..038b5f505b1d 100644 --- a/prover/witness_vector_generator/src/lib.rs +++ b/prover/witness_vector_generator/src/lib.rs @@ -1,3 +1,4 @@ +#![allow(incomplete_features)] // We have to use generic const exprs. #![feature(generic_const_exprs)] pub mod generator; diff --git a/prover/witness_vector_generator/src/main.rs b/prover/witness_vector_generator/src/main.rs index 9b5e8ffb7483..cb61be4227c9 100644 --- a/prover/witness_vector_generator/src/main.rs +++ b/prover/witness_vector_generator/src/main.rs @@ -1,3 +1,4 @@ +#![allow(incomplete_features)] // We have to use generic const exprs. #![feature(generic_const_exprs)] use std::time::Duration;