Inaccurate gas estimation

[Karrq]

Component

Forge

Have you ensured that all of these are up to date?

• Foundry
• Foundryup

What version of Foundry are you on?

forge 0.0.2 (8cb46fa 2024-06-05T13:34:46.413496000Z)

What command(s) is the bug in?

forge script

Operating System

None

Describe the bug

When using forge script to deploy contracts, forge attempts to calculate the exact gas required to execute a given transaction on the target chain (with --broadcast flag).

Currently, this estimation is inaccurate due to differing gas parameters, which sometimes can lead to failures when broadcasting these transactions on chain.

[dutterbutter]

@Karrq is this still relevant, if so what is the status?

[Karrq]

We did improve gas estimation considerably recently, but haven't been able to check the results of the estimation personally, so we need to run some tests before updating the issue

/cc @elfedy

[elfedy]

As of today, the estimation (which involves txs running locally using the rpc fork parameters) is in fact innacurate because the fee parameters are not being correctly used in the local vm, however the gas limit of the tx is overriden with the estimation from an rpc call, which currently renders the simulation useless for us. We should at least show the right gas parameters and also do some tests comparing the estimation vs rpc_call, maybe it makes sense to use the estimation directly.

[dutterbutter]

@elfedy is this closed from #773?