Skip to content
This repository has been archived by the owner on Mar 19, 2022. It is now read-only.

patched libs take lower precedence to those included in user-defined cookbooks #298

Conversation

michaelglass
Copy link
Contributor

addresses #296

@michaelglass
Copy link
Contributor Author

I believe this fixes it but I guess I should actually try it out...

@michaelglass
Copy link
Contributor Author

so: currently berksfile and cheffile cookbooks, if not explicitly listed in cookbook_paths still get lower precedence.

if explicitly listed in cookbook_paths, this fixes my issue

@tmatilai
Copy link
Collaborator

What about fixing that, too. I think the precedence should be from lowest to highest:

  • patch_cookbooks_path
  • Berkshelf/Librarian path
  • User configured cookbook_path

Maybe this would work?

@michaelglass
Copy link
Contributor Author

agree with you wholeheartedly. Don't have the cycles to work on this any more today but I'll take a stab on Monday.

@tmatilai
Copy link
Collaborator

Excellent, thanks!

@michaelglass
Copy link
Contributor Author

@tmatilai thanks for the suggestion. Done.

@tmatilai
Copy link
Collaborator

Looks good to me (without testing it). Thanks!

@michaelglass
Copy link
Contributor Author

I guess I should actually test it by hand. doing that now.

@michaelglass
Copy link
Contributor Author

works like a charm.

@matschaffer
Copy link
Owner

Nice! Looks like a nice clean patch too. Thanks!

matschaffer added a commit that referenced this pull request Oct 15, 2013
…precedence

patched libs take lower precedence to those included in user-defined cookbooks
@matschaffer matschaffer merged commit ebf489f into matschaffer:master Oct 15, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants