Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATA RACE in dynamicShardsPool #657

Closed
zhangxu19830126 opened this issue Jan 11, 2022 · 0 comments · Fixed by #658
Closed

DATA RACE in dynamicShardsPool #657

zhangxu19830126 opened this issue Jan 11, 2022 · 0 comments · Fixed by #658
Assignees
@zhangxu19830126
Labels
kind/bug Something isn't working needs-triage
Milestone
v0.3.0

Comments

@zhangxu19830126
Copy link
Collaborator 

WARNING: DATA RACE
Read at 0x00c001e6fea8 by goroutine 169:
  github.com/matrixorigin/matrixcube/raftstore.(*dynamicShardsPool).isStartedLocked()
      /Users/lni/src/matrixcube/raftstore/store_shards_pool.go:305 +0x84
  github.com/matrixorigin/matrixcube/raftstore.(*dynamicShardsPool).maybeCreate()
      /Users/lni/src/matrixcube/raftstore/store_shards_pool.go:317 +0x95
  github.com/matrixorigin/matrixcube/raftstore.(*dynamicShardsPool).startLocked.func1()
      /Users/lni/src/matrixcube/raftstore/store_shards_pool.go:290 +0x407
  github.com/matrixorigin/matrixcube/util/stop.(*Stopper).doRunCancelableTask.func1()
      /Users/lni/src/matrixcube/util/stop/stopper.go:254 +0xf2

Previous write at 0x00c001e6fea8 by goroutine 49:
  github.com/matrixorigin/matrixcube/raftstore.TestShardsPoolStartAndStop()
      /Users/lni/src/matrixcube/raftstore/store_shards_pool_test.go:327 +0x819
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47
@zhangxu19830126 zhangxu19830126 added kind/bug Something isn't working needs-triage labels Jan 11, 2022
@zhangxu19830126 zhangxu19830126 self-assigned this Jan 11, 2022
@zhangxu19830126 zhangxu19830126 added this to the v0.3.0 milestone Jan 11, 2022
@zhangxu19830126 zhangxu19830126 mentioned this issue Jan 11, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhangxu19830126 zhangxu19830126

Labels
kind/bug Something isn't working needs-triage
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Fix data race zhangxu19830126/matrixcube
1 participant
@zhangxu19830126