Use CA-signed TLS keys for testing #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that synapse requires real certs, we should present real certs.
We could just turn off the cert validation in synapse, but it seems nicer to
use a fake CA.
The CA key/cert were generated with:
openssl genrsa -out ca.key 2048
openssl req -new -x509 -key ca.key -days 3650 -out ca.crt
We could generate them dynamically, but it's easier to store them.
erikjohnston
reviewed
Jun 6, 2019
| tls_private_key_path => $self->{paths}{key_file}, | ||
| federation_custom_ca_list => [ | ||
| "$cwd/keys/ca.crt", | ||
| ], | ||
| use_insecure_ssl_client_just_for_testing_do_not_use => 1, |
There was a problem hiding this comment.
Can we not turn this off then? Or what? I'm a bit confused about what has real certs and what doesn't.
There was a problem hiding this comment.
this setting controls synapse's 'simple http client', which is used for non-federation requests, including (it turns out) some to IS servers. There's no way to set a custom CA for that, hence the setting.
This should probably be in a comment in the sytest code...
erikjohnston
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that synapse requires real certs, we should present real certs.
We could just turn off the cert validation in synapse, but it seems nicer
to use a fake CA.
The CA key/cert were generated with:
openssl genrsa -out ca.key 2048
openssl req -new -x509 -key ca.key -days 3650 -out ca.crt
We could generate the CA cert and key dynamically, but it's easier to store
them.