Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banned user tests differ for local and remote #940

Open
oliverpool opened this issue Aug 25, 2020 · 0 comments
Open

Banned user tests differ for local and remote #940

oliverpool opened this issue Aug 25, 2020 · 0 comments

Comments

@oliverpool
Copy link

oliverpool commented Aug 25, 2020

I was looking at matrix-org/dendrite#1331 and found the following.

In the ban test (https://github.com/matrix-org/sytest/blob/develop/tests/30rooms/07ban.pl) the Remote banned user has the following check, which is not present on the local user:

->then( sub {
         repeat_until_true {
            matrix_get_room_state( $banned_user, $room_id,
               type      => "m.room.member",
               state_key => $banned_user->user_id,
            )->main::check_http_code(
               403 => "ok",
               200 => "redo",
            );
         };
      })

If I read the spec correctly, the matrix_get_room_state should not return a 403 (You aren't a member of the room and weren't previously a member of the room.: the user was a member before being banned).

I guess those lines should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant