Check that current state events are in timeline #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
requested changes
Sep 18, 2017
tests/31sync/06state.pl
Outdated
|
|
||
| # Test to check that current state events appear in the timeline, | ||
| # even if they were set during a period the user couldn't see | ||
| test "Current state appears in timeline in private history", |
There was a problem hiding this comment.
please could you add a reference to a github bug (preferably a synapse one, but an ios one would do)?
| $_->{type} eq "m.room.member" | ||
| && $_->{state_key} eq $invitee->user_id | ||
| && $_->{content}{membership} eq "join" | ||
| } @{ $room->{timeline}{events} } |
There was a problem hiding this comment.
not sure I'd expect this to appear in the timeline, but ymmv
There was a problem hiding this comment.
It can't really be put in the "state" part, as that specifically is for state at the start of the timeline, which would rightly have the "invite" in. It does feel quite icky though :/
|
|
||
| Future->done( 1 ); | ||
| }) | ||
| }; |
There was a problem hiding this comment.
Sigh. This is what I get for switching editor from one that auto inserts new line at the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.