Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Improve tracing for to device messages #9686

Merged
merged 7 commits into from
Apr 1, 2021
Merged

Improve tracing for to device messages #9686

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
274bba4
Add message ID to local messages
erikjohnston Mar 23, 2021
4cc1915
Trace message ID
erikjohnston Mar 22, 2021
149306c
Fix missing log context
erikjohnston Mar 25, 2021
ca82abc
Don't include message_id in /sync response
erikjohnston Mar 25, 2021
62dab8c
Newsfile
erikjohnston Mar 25, 2021
3e1dc96
Fix typo
erikjohnston Apr 1, 2021
d52356a
Merge remote-tracking branch 'origin/develop' into erikj/trace_msg_id
erikjohnston Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion synapse/handlers/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@

from synapse.api.errors import AuthError, ShadowBanError, SynapseError
from synapse.appservice import ApplicationService
from synapse.metrics.background_process_metrics import run_as_background_process
from synapse.metrics.background_process_metrics import (
run_as_background_process,
wrap_as_background_process,
)
from synapse.replication.tcp.streams import TypingStream
from synapse.types import JsonDict, Requester, UserID, get_domain_from_id
from synapse.util.caches.stream_change_cache import StreamChangeCache
Expand Down Expand Up @@ -86,6 +89,7 @@ def _reset(self) -> None:
self._member_last_federation_poke = {}
self.wheel_timer = WheelTimer(bucket_size=5000)

@wrap_as_background_process("typing.run_as_background_process")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "typing._handle_timeouts" or similar instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... yes

def _handle_timeouts(self) -> None:
logger.debug("Checking for typing timeouts")

Expand Down