Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Always send the user updates to their own device list #7160

Merged
merged 7 commits into from
Mar 30, 2020

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Mar 27, 2020

This will allow clients to notify users about new devices even if
the user isn't in any rooms (yet).

dbkr added 4 commits March 27, 2020 12:26
This will allow clients to notify users about new devices even if
the user isn't in any rooms (yet).
@dbkr dbkr requested a review from a team March 27, 2020 13:18
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly lgtm.

We should watch out for any code however that assumes that the current user's ID wouldn't be included in this list, as it doesn't seem like get_users_who_share_room_with_user would ever return back the user_id that it was given.

synapse/handlers/sync.py Outdated Show resolved Hide resolved
@dbkr
Copy link
Member Author

dbkr commented Mar 30, 2020

Mmm, true. I've made it so we just add ourselves to the set of users we get device changes for which should be clearer and less error-prone.

@dbkr dbkr requested a review from anoadragon453 March 30, 2020 09:20
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richvdh
Copy link
Member

richvdh commented Apr 22, 2020

this was backported into the release-v1.12.4 branch with 40f79f5.

richvdh added a commit that referenced this pull request Apr 22, 2020
Synapse 1.12.4rc1 (2020-04-22)
==============================

Features
--------

- Always send users their own device updates. ([\#7160](#7160))
- Add support for handling GET requests for `account_data` on a worker. ([\#7311](#7311))

Bugfixes
--------

- Fix a bug that prevented cross-signing with users on worker-mode synapses. ([\#7255](#7255))
- Do not treat display names as globs in push rules. ([\#7271](#7271))
- Fix a bug with cross-signing devices belonging to remote users who did not share a room with any user on the local homeserver. ([\#7289](#7289))
clokep added a commit that referenced this pull request Apr 23, 2020
Synapse v1.12.4

Features:

* Always send users their own device updates. (#7160)
* Add support for handling GET requests for account_data on a worker. (#7311)

Bugfixes:

* Fix a bug that prevented cross-signing with users on worker-mode synapses. (#7255)
* Do not treat display names as globs in push rules. (#7271)
* Fix a bug with cross-signing devices belonging to remote users who did not share a
  room with any user on the local homeserver. (#7289)
anoadragon453 added a commit that referenced this pull request Apr 24, 2020
…anoa/temp_working_cache_config

* 'release-v1.12.4' of github.com:matrix-org/synapse: (123 commits)
  1.12.4
  formatting for the changelog
  1.12.4rc1
  1.12.4rc1
  Do not treat display names as globs for push rules. (#7271)
  Query missing cross-signing keys on local sig upload (#7289)
  Fix changelog file
  Support GET account_data requests on a worker (#7311)
  Revert "Query missing cross-signing keys on local sig upload"
  Always send the user updates to their own device list (#7160)
  Query missing cross-signing keys on local sig upload
  Only register devices edu handler on the master process (#7255)
  tweak changelog
  1.12.3
  Fix the debian build in a better way. (#7212)
  Fix changelog wording
  1.12.2
  Pin Pillow>=4.3.0,<7.1.0 to fix dep issue
  1.12.1
  Note where bugs were introduced
  ...
phil-flex pushed a commit to phil-flex/synapse that referenced this pull request May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
z-cross-signing-sprint (Deprecated Label)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants