From 916bc21efb1fc982919a77c212577417858461d6 Mon Sep 17 00:00:00 2001 From: santhoshivan23 Date: Tue, 28 Jun 2022 12:51:25 +0530 Subject: [PATCH 1/3] Remove unspecced DELETE endpoint that modifies room visibility Signed-off-by: santhoshivan23 --- synapse/rest/client/directory.py | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/synapse/rest/client/directory.py b/synapse/rest/client/directory.py index d6c89cb16297..bc1b18c92d8e 100644 --- a/synapse/rest/client/directory.py +++ b/synapse/rest/client/directory.py @@ -151,17 +151,6 @@ async def on_PUT( return 200, {} - async def on_DELETE( - self, request: SynapseRequest, room_id: str - ) -> Tuple[int, JsonDict]: - requester = await self.auth.get_user_by_req(request) - - await self.directory_handler.edit_published_room_list( - requester, room_id, "private" - ) - - return 200, {} - class ClientAppserviceDirectoryListServer(RestServlet): PATTERNS = client_patterns( From f6b4b658b7409620c3565b8764fbd580dd39abb9 Mon Sep 17 00:00:00 2001 From: santhoshivan23 Date: Tue, 28 Jun 2022 13:04:59 +0530 Subject: [PATCH 2/3] Add Changelog entry for PR #13123 Signed-off-by: santhoshivan23 --- changelog.d/13123.removal | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/13123.removal diff --git a/changelog.d/13123.removal b/changelog.d/13123.removal new file mode 100644 index 000000000000..9f32f2ad0b90 --- /dev/null +++ b/changelog.d/13123.removal @@ -0,0 +1 @@ +Remove an unspecced DELETE endpoint that modifies room visibility, which has an equivalent implementation using PUT. \ No newline at end of file From de1925a44ac7573881c64fd0530963c44e1d32b4 Mon Sep 17 00:00:00 2001 From: David Robertson Date: Tue, 28 Jun 2022 11:51:07 +0100 Subject: [PATCH 3/3] Update changelog.d/13123.removal --- changelog.d/13123.removal | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelog.d/13123.removal b/changelog.d/13123.removal index 9f32f2ad0b90..f013f16163c3 100644 --- a/changelog.d/13123.removal +++ b/changelog.d/13123.removal @@ -1 +1 @@ -Remove an unspecced DELETE endpoint that modifies room visibility, which has an equivalent implementation using PUT. \ No newline at end of file +Remove the unspecced `DELETE /directory/list/room/{roomId}` endpoint, which hid rooms from the [public room directory](https://spec.matrix.org/v1.3/client-server-api/#listing-rooms). Instead, `PUT` to the same URL with a visibility of `"private"`. \ No newline at end of file