This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add /state_ids federation API #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new API only returns the event_ids for the state, as most requesters will already have the vast majority of the events already.
| defer.returnValue((pdus, auth_chain)) | ||
| except HttpResponseException as e: | ||
| if e.code == 404: | ||
| logger.info("Failed to use get_room_state_ids API, falling back") |
There was a problem hiding this comment.
Are you actually falling back here? I'm not seeing any calls to transport_layer.get_room_state
| ] | ||
|
|
||
| res = yield defer.DeferredList(deferreds, consumeErrors=True) | ||
| for (result, val), (e_id, _) in res: |
There was a problem hiding this comment.
Why is it (result,val), (e_id, _) here but (r, e), e_id) in the list comprehension above. What's the difference between result and val.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new API only returns the event_ids for the state, as most requesters will already have the vast majority of the events already.