This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Change the way we summarize URLs #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using XPath is slow on some machines (for unknown reasons), so use a different approach to get a list of text nodes. Try to generate a summary that respect paragraph and then word boundaries, adding ellipses when appropriate.
| new_desc = "" | ||
|
|
||
| # This splits the paragraph into words, but keeping the | ||
| # (proceeding) whitespace intact so we can easily concat |
| new_desc = new_desc[:MAX_SIZE] | ||
|
|
||
| # We always add an ellipsis because at the very least | ||
| # we chooped mid paragraph. |
|
lgtm modulo a test :) |
erikjohnston
force-pushed
the
erikj/xpath_fix
branch
from
7e3b2b8 to
e97648c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using XPath is slow on some machines (for unknown reasons), so use a different approach to get a list of text nodes.
Try to generate a summary that respect paragraph and then word boundaries, adding ellipses when appropriate.