This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Handle the case of missing auth events when joining a room #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1155,7 +1155,7 @@ def _handle_new_events(self, origin, event_infos, backfilled=False): | |||
| ) | |||
|
|
|||
| @defer.inlineCallbacks | |||
| def _persist_auth_tree(self, auth_events, state, event): | |||
| def _persist_auth_tree(self, origin, auth_events, state, event): | |||
| """Checks the auth chain is valid (and passes auth checks) for the | |||
| state and event. Then persists the auth chain and state atomically. | |||
| Persists the event seperately. | |||
There was a problem hiding this comment.
Maybe update the docstring with the changes?
|
@NegativeMjark PTAL |
| @@ -1160,6 +1160,12 @@ def _persist_auth_tree(self, origin, auth_events, state, event): | |||
| state and event. Then persists the auth chain and state atomically. | |||
| Persists the event seperately. | |||
There was a problem hiding this comment.
Could you add a couple of lines explaining that it will fetch missing events, and under what conditions it will do so?
|
Eh LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.