Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Use chain cover index in get_auth_chain_ids #9482

Closed
clokep opened this issue Feb 24, 2021 · 1 comment · Fixed by #9576
Closed

Use chain cover index in get_auth_chain_ids #9482

clokep opened this issue Feb 24, 2021 · 1 comment · Fixed by #9576
Assignees
@clokep
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@clokep
Copy link
Member

clokep commented Feb 24, 2021

We have an instance of Synapse that is spending a lot of CPU time in get_auth_chain_ids. @erikjohnston suggested the CPU load could be reduced:

but we should probably just make get_auth_chain_ids use the chain cover index (its just a simplified version of get_auth_chain_diff), which should be much faster
@clokep clokep added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Feb 24, 2021
@richvdh
Copy link
Member

richvdh commented Feb 24, 2021

this might help with #7893.

@richvdh richvdh mentioned this issue Feb 24, 2021
Closed
@clokep clokep self-assigned this Mar 9, 2021
@clokep clokep mentioned this issue Mar 9, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the chain cover index in get_auth_chain_ids matrix-org/synapse
2 participants
@clokep @richvdh