Add device_id support to /login #929
Conversation
Add a 'devices' table to the storage, as well as a 'device_id' column to refresh_tokens. Allow the client to pass a device_id, and initial_device_display_name, to /login. If login is successful, then register the device in the devices table if it wasn't known already. If no device_id was supplied, make one up. Associate the device_id with the access token and refresh token, so that we can get at it again later. Ensure that the device_id is copied from the refresh token to the access_token when the token is refreshed.
richvdh
force-pushed
the
rav/support_deviceid_in_login
branch
from
e260ff3 to
f863a52
Compare
|
hrm, will investigate sytest fails |
device_id should be text, not bigint.
| @@ -372,6 +372,7 @@ def get_login_tuple_for_user_id(self, user_id): | |||
|
|
|||
| Args: | |||
| user_id (str): canonical User ID | |||
| device_id (str): the device ID to associate with the access token | |||
| Returns: | |||
There was a problem hiding this comment.
What does a None device id mean?
There was a problem hiding this comment.
It means "this access token is not associated with a device".
|
Do we actually use the fact that |
Well, certainly at this point, the registration flow still generates access_tokens without device_ids. In general, I'm not confident in my ability to comb exhaustively through the code (yay dynamic languages) and make sure that a device_id is generated in all the places we need one, and would rather be a bit defensive and try to make sure that things keep working rather than throwing runtime exceptions. |
|
LGTM (Would be good to see some sytests that hit the code paths) |
Add a 'devices' table to the storage, as well as a 'device_id' column to refresh_tokens.
Allow the client to pass a device_id, and initial_device_display_name, to /login. If login is successful, then register the device in the devices table if it wasn't known already. If no device_id was supplied, make one up.
Associate the device_id with the access token and refresh token, so that we can get at it again later. Ensure that the device_id is copied from the refresh token to the access_token when the token is refreshed.
(Next step in this process will be to also support 'device_id' in the registration API).