Feature: Implement purge_media_cache admin API #902

erikjohnston · 2016-06-29T13:58:59Z

Adds an API to purge old remote media that has been locally cached. API:

POST /_matrix/client/api/v1/admin/purge_media_cache?access_token=X&before_ts=1467208470882

200 OK
{
    "deleted": 5
}

This purges all cached remote media that was last accessed before the time given by before_ts.

The requester must be a server admin.

NegativeMjark · 2016-06-29T14:06:04Z

synapse/rest/media/v1/media_repository.py

+
+                yield self.store.delete_remote_media(origin, media_id)
+                try:
+                    os.removedirs(thumbnail_dir)


Hmm, will this race with adding an item under a different key?

NegativeMjark · 2016-06-29T14:25:16Z

LGTM

erikjohnston added 2 commits June 29, 2016 11:41

Track approximate last access time for remote media

314b146

Implement purge_media_cache admin API

a706884

erikjohnston assigned NegativeMjark Jun 29, 2016

erikjohnston changed the title ~~Implement purge_media_cache admin API~~ Feature: Implement purge_media_cache admin API Jun 29, 2016

NegativeMjark reviewed Jun 29, 2016
View reviewed changes

Remove race

f52cb4c

erikjohnston merged commit aac546c into develop Jun 29, 2016

richvdh deleted the erikj/expire_media branch December 1, 2016 14:09

Provide feedback