Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

If a server reaches its MAU, it is no longer able to create appservice users. #8960

Closed
Half-Shot opened this issue Dec 17, 2020 · 4 comments · Fixed by #8962
Closed

If a server reaches its MAU, it is no longer able to create appservice users. #8960

Half-Shot opened this issue Dec 17, 2020 · 4 comments · Fixed by #8962
Assignees
Labels
A-Application-Service Related to AS support T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. z-bug (Deprecated Label)

Comments

@Half-Shot
Copy link
Collaborator

Note, bridge users do not count against MAU. However if your homeserver reaches the MAU limit with real users and then an appservice tries to register ghost users, it will fail with "errcode":"M_RESOURCE_LIMIT_EXCEEDED","error":"Monthly Active User Limit Exceeded"

This may also be the case for other custom user types too.

@Half-Shot Half-Shot added A-Application-Service Related to AS support z-bug (Deprecated Label) labels Dec 17, 2020
@rxl881
Copy link

rxl881 commented Dec 17, 2020

@danc86 -- Is there any chance that we would be able to get a hot-fix for this relatively quickly?

@Half-Shot
Copy link
Collaborator Author

Offending registration check:

# do not check_auth_blocking if the call is coming through the Admin API
if not by_admin:
await self.auth.check_auth_blocking(threepid=threepid)

More generally

async def check_auth_blocking(
should probably not block actions from appservice users.

@callahad
Copy link
Contributor

With apologies to @danc86 -- I'm @callahad, he's someone else :)

@richvdh richvdh changed the title If a server reaches it's MAU, it is no longer able to create appservice users. If a server reaches its MAU, it is no longer able to create appservice users. Dec 17, 2020
@rxl881
Copy link

rxl881 commented Dec 17, 2020

Whoops!! Sorry for the erroneous mention, I'm going to blame a combination of lack of coffee and over-dependence on auto-complete :( (thanks for catching that "the real" @callahad)

@MadLittleMods MadLittleMods added the T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. label Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Application-Service Related to AS support T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. z-bug (Deprecated Label)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants