This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Email unsubscribe links that don't require logging in #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Were it not for that fact that you can't use the base handler in the pusher because it pulls in the world. Comitting while I fix that on a different branch.
…r' into dbkr/email_unsubscribe
and authed by macaroons that let you delete pushers and nothing else
|
LGTM, other than PEP8 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the unsubscribe links in emails go direct to a synapse GET API that deletes the pusher in question, authed by a macaroon that allows you to delete pushers and nothing else.
Could do with tests, but the best way to do this would be to add a way of getting delete_pusher macaroons other than receiving them by email, which would probably be an extension to the login API.