-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Added basic keycloak openid instructions #7659
Conversation
Am I suppose to create an issue page and change log? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I requested a few changes, but they're all rather minor. Thanks for adding this example!
Looks like you've got everything you need! |
Added clokep's suggested changes Signed-off-by: Ted Chang <[email protected]>
@clokep done |
Changed a few descriptions
Thanks! 👍 |
@clokep , You could have told me and I would have squashed my commits. I am sorry. I polluted the history by spreading through 5 different commits which is excessive. |
Nevermind, I did not know github auto squash commits. Cool |
Yeah, there's a little drop down where you can choose to do a merge, a squash or a rebase. For synapse we generally do a squash to keep the history linear! |
* commit '5c5516f80': Add instructions for authing with Keycloak via OpenID (#7659)
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.