This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Implement basic ignore user API #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -60,6 +63,28 @@ def get_account_data_for_user_txn(txn): | |||
| "get_account_data_for_user", get_account_data_for_user_txn | |||
| ) | |||
|
|
|||
| @cachedInlineCallbacks(num_args=2) | |||
| def get_global_account_data_by_type_for_user(self, user_id, data_type): | |||
There was a problem hiding this comment.
Given how this is used maybe this wants to be a cached list and for the function to take a list of userids rather than a single user?
|
Would it be an idea to create a special cached database API for getting the ignore list that could populate the cache with a default empty list if the user hasn't set an ignore list? |
In terms of performance or code neatness? |
erikjohnston
force-pushed
the
erikj/ignore_user
branch
from
6fdba2e to
1f0f5ff
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.