This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Implement room version 6 (MSC2240). #7506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some sytests: matrix-org/sytest#869. |
6 tasks
|
I should mention that I wasn't positive if it made sense to blow away the experimental room versions, but I doubt people are using them in this case (and two of them were never in a released version of Synapse). |
richvdh
approved these changes
May 15, 2020
There was a problem hiding this comment.
lgtm.
Killing the experimental versions is fine, we've done it in the past, though #7083 is a thing.
IIRC there is some stuff in sytest which (a) defines the room versions that the sytest federation server impl supports (b) defines a set of room versions over which a subset of tests are run for. It would be good to update that,
|
I believe I've done that in the PR referenced above: matrix-org/sytest@8b87284 I need to finish that up still. |
|
oops sorry, missed that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7500
This implements room version 6 and removes some experimental room versions.