This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Add get endpoint for pushers #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,14 +27,47 @@ | |||
|
|
|||
|
|
|||
| class PusherRestServlet(ClientV1RestServlet): | |||
| PATTERNS = client_path_patterns("/pushers/set$") | |||
| PATTERNS = client_path_patterns("/pushers(/set)?$") | |||
There was a problem hiding this comment.
Would probably be clearer if this was split into two, since /pushers is only valid for GET and /pushers/set is only valid for POST
There was a problem hiding this comment.
Done. Was debating which was neater but I think you're right.
This was referenced Apr 12, 2016
Decodes pushers rows on the main thread rather than the db thread and uses _simple_select_list. Also do the same to the function I copied and factor out the duplication into a helper function.
|
ptal |
| "last_stream_ordering", | ||
| "last_success", | ||
| "failing_since", | ||
|
|
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per matrix-org/matrix-spec-proposals#308
Tested by matrix-org/sytest#227