This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix stuck invites #691
Merged
Fix stuck invites #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If rejecting a remote invite fails with an error response don't fail the entire request; instead mark the invite as locally rejected. This fixes the bug where users can get stuck invites which they can neither accept nor reject.
|
LGTM |
|
For the record, this landed in synapse 0.15.0-rc1 (2016-04-26), but 0.15.0 wasn't released, so this finally got released in 0.16.0 (2016-06-09). |
|
Will it be deployed to matrix.org any time soon, though? Can't wait to get rid of those invites. |
|
it was deployed to matrix.org over a year ago. If you have stuck invites, it's something else. Please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If rejecting a remote invite fails with an error response don't fail the entire request; instead mark the invite as locally rejected.
This fixes the bug where users can get stuck invites which they can neither accept nor reject.