Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix issues with JWT login #687

Merged
merged 1 commit into from
Apr 21, 2016
Merged

Conversation

nikriek
Copy link
Contributor

@nikriek nikriek commented Apr 1, 2016

No description provided.

@matrixbot
Copy link
Member

Can one of the admins verify this patch?

3 similar comments
@matrixbot
Copy link
Member

Can one of the admins verify this patch?

@matrixbot
Copy link
Member

Can one of the admins verify this patch?

@matrixbot
Copy link
Member

Can one of the admins verify this patch?

@nikriek nikriek force-pushed the jwt-fix branch 3 times, most recently from 5b8d1b1 to 85a06e5 Compare April 1, 2016 17:31
@erikjohnston
Copy link
Member

@matrixbot ok to test

@nikriek
Copy link
Contributor Author

nikriek commented Apr 2, 2016

Give me one day. I thought about adding another configuration parameter.

@erikjohnston
Copy link
Member

Any news?

@nikriek
Copy link
Contributor Author

nikriek commented Apr 14, 2016

Jep, few things. I will finish it this weekend!

@erikjohnston
Copy link
Member

No problem! Just checking you're alive :)

@nikriek
Copy link
Contributor Author

nikriek commented Apr 19, 2016

Actually I was already done. I thought about adding another config var that allows to change the key to get the user identifier. But in my understanding the sub key should sufficient

Btw: The Flake8 link is invalid.

@erikjohnston
Copy link
Member

Ok cool, will try and have a look tomorrow :)

@matrixbot: test this please

@erikjohnston
Copy link
Member

login.py:229 line is too long.

Other than that it looks good.

@nikriek
Copy link
Contributor Author

nikriek commented Apr 21, 2016

Done :)

@erikjohnston
Copy link
Member

(Looks like that test spuriously timed out.)

Thanks for this!

@erikjohnston erikjohnston merged commit b9675ef into matrix-org:develop Apr 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants