Remote aliases aren't moved to new room on room upgrade.

[mvgorcum]

Description:

[richvdh]

Could someone explain like I'm five what exactly the problem is here?

[mvgorcum]

I haven't tested all permutations, but this is what I found:

@exampleuser:server1.com creates room, adds alias #alias:server1.com. @exampleuser2:server2.com joins and adds #alias2:server2.com.

@exampleuser:server1.com upgrades the room to another room version. #alias:server1.com gets moved to the new room, but #alias2:server2.com does not get moved.

[anoadragon453]

@mvgorcum Does the second alias get moved when a user from server2.com joins the upgraded room?

[anoadragon453]

Just tested and indeed remote aliases don't ever get moved. We should move them when the server processes the create event for the first time, just like other room attributes.

[mvgorcum]

Yeah, if @exampleuser2:server2.com joins that doesn't trigger an alias move.

Things I haven't tested include: what if @exampleuser2:server2.com upgrades the room, or if @exampleuser3:server3.com doesn't set an alias, but does upgrade the room? etc.

Also: apologies for not spelling it out properly in the first place

[richvdh]

related: #6842

[anoadragon453]

Fixed by #6946