This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Avoid attribute error when password_config present but empty
#6753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old statement returned `None` for such a `password_config` (like the one created on first run), thus retrieval of the `pepper` key failed with `AttributeError`. Fixes matrix-org#5315 Signed-off-by: Ivan Vilata i Balaguer <[email protected]>
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '837f62266': Avoid attribute error when `password_config` present but empty (#6753)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old statement returned
Nonefor such apassword_config(like the onecreated on first run), thus retrieval of the
pepperkey failed withAttributeError.Fixes #5315
Signed-off-by: Ivan Vilata i Balaguer [email protected]