This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Process EDUs in parallel with PDUs. #6697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also process them in parallel like we do for PDUs.
This means that things like to device messages don't get blocked behind processing PDUs, which can potentially take *ages*.
erikjohnston
force-pushed
the
erikj/edu_processing_parallel
branch
from
2eee0b3 to
1269e28
Compare
|
Is this #5175 ? |
This still blocks responding to the |
anoadragon453
approved these changes
Jan 14, 2020
| run_in_background(self._handle_edus_in_txn, origin, transaction), | ||
| ], | ||
| consumeErrors=True, | ||
| ).addErrback(unwrapFirstError) |
There was a problem hiding this comment.
I'm not entirely sure how the error handling is working here. Will this raise an exception if one of the wrapped methods raise?
There was a problem hiding this comment.
This is basically a copy from: https://github.com/matrix-org/synapse/blob/master/synapse/util/async_helpers.py#L167-L186
The way defer.gatherResults works is that:
consumeErrors=Truemeans that it won't report errors to the default "unhandled error" logginggatherResultswill raise aFirstErrorthat wrapse the actual exception. This is a bit annoying as we might be attempting to handle particular exceptions further up the stack, so we useunwrapFirstErrorwhich does what it says on the tin.
Co-Authored-By: Andrew Morgan <[email protected]>
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'b5ce7f587': Process EDUs in parallel with PDUs. (#6697)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that things like to device messages don't get blocked behind processing PDUs, which can potentially take ages if e.g. the server has been down for a while and has a lot to catch up on.