Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Refuse to start if sqlite is older than 3.11.0 #6675

Merged
merged 5 commits into from
Jan 10, 2020

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jan 9, 2020

There's some other refactory stuff here to make this easier; it might be easier to review the commits independently.

Fixes #6672.

@richvdh richvdh requested a review from a team January 9, 2020 17:53
this saves doing it on each connection, and will allow us to pass extra options
in.
@richvdh richvdh force-pushed the rav/die_sqlite37_die_die_die branch from ef297a2 to d30f46f Compare January 9, 2020 18:07
@richvdh richvdh force-pushed the rav/die_sqlite37_die_die_die branch from d30f46f to 937dea4 Compare January 9, 2020 18:11
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪 🔪 🔪

@richvdh richvdh merged commit 1d16f5e into develop Jan 10, 2020
@richvdh richvdh deleted the rav/die_sqlite37_die_die_die branch January 10, 2020 12:17
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '1d16f5ea0':
  update install notes for CentOS
  changelog
  Refuse to start if sqlite is older than 3.11.0
  Check postgres version in check_database
  Modify check_database to take a connection rather than a cursor
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants