This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Reduce the reconnect time when replication fails. #6617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
reviewed
Jan 2, 2020
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '6964ea095': Reduce the reconnect time when replication fails. (#6617)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thinking here is that, if we wait a full 30 seconds, there's a good chance that there will be a huge volume of data waiting for us, so we'll get booted straight off again, and never successfully reconnect. OTOH even if we end up tight-looping on a reconnection, one connection every second isn't so bad.
This is all something of a sticking-plaster, of course: ideally there would be a separate "catching up mode" in which we wouldn't get booted straight off again.
Helps to mitigate #6602.