This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Port some of FederationHandler to async/await #6517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/event_auth/13
branch
2 times, most recently
from
d7dc51a to
1ac70c1
Compare
PaginationHandler.get_messages is only called by RoomMessageListRestServlet, which is async. Chase the code path down from there: - FederationHandler.maybe_backfill (and nested try_backfill) - FederationHandler.backfill
and associated functions: * on_receive_pdu * handle_queued_pdus * get_missing_events_for_pdu
... and _get_events_from_store_or_dest
also fix user_joined_room to consistently return deferreds
richvdh
force-pushed
the
rav/event_auth/13
branch
from
1ac70c1 to
5324bc2
Compare
erikjohnston
approved these changes
Dec 11, 2019
48 tasks
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '894d2adda': changelog convert to async: FederationHandler._process_received_pdu convert to async: FederationHandler._get_state_for_room convert to async: FederationHandler.on_receive_pdu Convert federation backfill to async
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry this is a bit of a big diff. it might be easier to review it by commit.