Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix race which caused deleted devices to reappear #6514

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Dec 10, 2019

Stop the update_client_ips background job from recreating deleted devices.

Stop the `update_client_ips` background job from recreating deleted devices.
@richvdh richvdh requested a review from a team December 10, 2019 15:07
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the test failures are due to badly written tests?

@richvdh
Copy link
Member Author

richvdh commented Dec 10, 2019

indeed

@richvdh richvdh merged commit 40eda84 into develop Dec 10, 2019
@richvdh richvdh deleted the rav/fix_delete_devices_race branch December 10, 2019 16:22
anoadragon453 added a commit that referenced this pull request Dec 11, 2019
…rch_redacted_events

* 'develop' of github.com:matrix-org/synapse: (100 commits)
  Move get_state methods into FederationHandler (#6503)
  Allow SAML username provider plugins (#6411)
  Fix race which caused deleted devices to reappear (#6514)
  Refactor get_events_from_store_or_dest to return a dict (#6501)
  Remove redundant code from event authorisation implementation. (#6502)
  Newsfile
  Silence mypy errors for files outside those specified
  Newsfile
  Phone home stats DB reporting should not assume a single DB.
  Update comment
  Drop unused index
  Convert _censor_redactions to async since it awaits on coroutines
  Only start censor background job after indices are created
  Newsfile
  Newsfile
  Fix make_deferred_yieldable to work with coroutines
  Newsfile
  Fix support for SQLite 3.7.
  Better errors regarding changing avatar_url (#6497)
  1.7.0rc1
  ...
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '40eda8493':
  Fix race which caused deleted devices to reappear (#6514)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants