Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove SnapshotCache in favour of ResponseCache #6506

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

erikjohnston
Copy link
Member

The only functional change here is to make the cache of /initialSync to expire immediately rather than after 5 minutes, bringing it in line with /sync. We can add timeout_ms=5 * 60 * 1000 if we want to bring them into line

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the timeout is important, but 🤷‍♂️

lgtm otherwise

@erikjohnston
Copy link
Member Author

Nothing should use global /initialSync anymore and its basically equivalent to doing an initial sync which doesn't have a timeout, so 🤷‍♂️

@richvdh
Copy link
Member

richvdh commented Dec 10, 2019

OHHH

@erikjohnston erikjohnston merged commit e3f528c into develop Dec 10, 2019
@erikjohnston erikjohnston deleted the erikj/remove_snapshot_cache branch January 9, 2020 15:47
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit 'e3f528c54':
  Newsfile
  Remove SnapshotCache in favour of ResponseCache
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants