Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add some checks that we aren't using state from rejected events #6330

Merged
merged 3 commits into from
Nov 5, 2019

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Nov 5, 2019

Just to try to catch potential bugs earlier.

Verified

This commit was signed with the committer’s verified signature.
renovate-bot Mend Renovate
Per review comments: add some sanity checks on accessing state_group etc for
rejected events.
It didn't actually cause any bugs, because rejected events get filtered out at
various later points, but there's not point in trying to calculate the push
actions for a rejected event.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@richvdh richvdh requested a review from a team November 5, 2019 15:04
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo

@richvdh richvdh merged commit 0e3ab8a into develop Nov 5, 2019
@richvdh richvdh deleted the rav/event_context/3 branch November 5, 2019 22:13
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '0e3ab8afd':
  Add some checks that we aren't using state from rejected events (#6330)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants