This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add optional python dependencies to snap packaging #6317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalrane
force-pushed
the
snapcraft-add-optional-deps
branch
2 times, most recently
from
50d920d to
b80b9fe
Compare
anoadragon453
approved these changes
Nov 7, 2019
Signed-off-by: James Hebden <[email protected]>
digitalrane
force-pushed
the
snapcraft-add-optional-deps
branch
from
b80b9fe to
71b82fd
Compare
|
Thanks for the review! I've updated the changelog entry to meet requirements. |
|
Looks good, thank you! |
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '53b6559a8': Add optional python dependencies to snap packaging (#6317)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
This PR adds the optional dependencies to snapcraft packaging, including required build and stage libraries to enable features such as PostgreSQL support.
NOTE: This is currently done by adding the '.[all]' requirement to the python-packages section of the snapcraft file, to avoid having to keep the snapcraft file up to date as dependencies change, and also to work around al imitation in snapcraft, noted in LP#1786939. Once this bug is fixed, then the method could be changed to use a supported snapcraft option to pull in additional dependencies based on the
extras_requiresection of setup.py directly.The additional stage and build packages are just used to ensure the required binary libraries which are needed by the optional dependencies are included in the resulting snap.
I have built and tested t his snap and am able to run a synapse instance using PostgreSQL as backing database based on these changes.
Signed-off-by: James Hebden [email protected]