Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Implement MSC2326 (label based filtering) #6301

Merged
merged 16 commits into from
Nov 1, 2019
Merged

Conversation

babolivier
Copy link
Contributor

@babolivier babolivier commented Oct 30, 2019

Implements label-based filtering following MSC2326.

A future improvement would be to implement a background update to populate the event_labels table with data from past events; I plan to do so in a separate PR this is #6310.

Fixes #6288

@babolivier babolivier requested a review from a team October 30, 2019 17:53
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits about comments below about comments, but generally lgtm

changelog.d/6301.feature Outdated Show resolved Hide resolved
synapse/api/constants.py Outdated Show resolved Hide resolved
synapse/api/filtering.py Show resolved Hide resolved
synapse/storage/data_stores/main/events.py Outdated Show resolved Hide resolved
@richvdh richvdh removed their assignment Oct 31, 2019
@babolivier babolivier requested a review from a team November 1, 2019 10:45
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit 'f496d2587':
  Incorporate review
  Factor out an _AsyncEventContextImpl (#6298)
  Update synapse/storage/data_stores/main/schema/delta/56/event_labels.sql
  Add more data to the event_labels table and fix the indexes
  Add unstable feature flag
  Lint
  Incorporate review
  Lint
  Changelog
  Add integration tests for /messages
  Add more integration testing
  Add integration tests for sync
  Add unit tests
  Add index on label
  Implement filtering
  Store labels for new events
  Add database table for keeping track of labels on events
@babolivier babolivier deleted the babolivier/msc2326 branch October 28, 2021 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants