This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
delete keys when deleting backup versions #6253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sytest failure is: which seems unrelated to my changes |
erikjohnston
suggested changes
Oct 25, 2019
tests/storage/test_e2e_room_keys.py
Outdated
| } | ||
|
|
||
|
|
||
| class E2eRoomKeysHandlerTestCase(unittest.TestCase): |
There was a problem hiding this comment.
Can you use HomeserverTestCase please? Its the new (ish) way of doing things such that we don't need to spin up a full reactor, and has a number of advantages.
Broadly, it works in the same way instead of doing @defer.inlineCallbacks and yield you can do self.get_success(self.store.some_deferred_returning_func())
|
Given that I only made changes the unit test, and the sytest is now passing, it sounds like the "Gapped incremental syncs include all state changes" test is flaky. |
erikjohnston
approved these changes
Oct 25, 2019
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'da78f6177': remove unneeded imports switch to using HomeserverTestCase remove some unnecessary lines add changelog delete keys when deleting backups
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.