This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Remove a bunch of dead event_auth code. #6214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't work, and afaict hasn't been used since 2015.
The only possible rejection reason is AUTH_ERROR, so all of this is unreachable.
erikjohnston
approved these changes
Oct 18, 2019
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '47ada4dff': changelog rip out some unreachable code Remove dead check_auth script
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check_auth dev script didn't work, and I don't think it's been used in years. Let's kill it off.
The only possible rejection reason is AUTH_ERROR, so there was a whole swathe of unrachable code starting in _update_auth_events_and_context_for_auth. Rip it out, along with the stuff in federation_client which was only used there.